Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes with the getting started tutorial #1244

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

polypixeldev
Copy link
Collaborator

This PR fixes a few things with the getting_started tutorial that I encountered while going through it with my club today.

  • Be consistent with using arrow functions instead of anonymous function expressions
  • Be consistent with using semicolons
  • Change the declaration of const tune = tune`...` to use the variable name myTune instead of tune, as the original declaration errors due to the identifier tune already being declared, and references to this variable name

Copy link

vercel bot commented Nov 16, 2023

@polypixeldev is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 5:15am

@grymmy
Copy link
Contributor

grymmy commented Nov 17, 2023

@LucasHT22 can you please perform a code review of this & test / give your opinion?

@LucasHT22
Copy link
Member

@LucasHT22 can you please perform a code review of this & test / give your opinion?

Sure! Will do.

Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this PR:)

@vercel vercel bot temporarily deployed to Preview – sprig November 19, 2023 05:15 Inactive
@grymmy grymmy merged commit 7e4d7d7 into hackclub:main Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants