Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add next lint script #82

Merged
merged 4 commits into from
Nov 7, 2021
Merged

Add next lint script #82

merged 4 commits into from
Nov 7, 2021

Conversation

exu3
Copy link
Member

@exu3 exu3 commented Nov 6, 2021

This PR adds the next lint script and fixes all the eslint warnings/errors.

Screen Shot 2021-11-06 at 11 20 48 AM

@lachlanjc
Copy link
Member

lachlanjc commented Nov 6, 2021 •
edited
Loading

📝 Changed routes:

/
Screenshot of /
(view full size)

Commit 5e63c17 (https://hackathons-r4wj1odxl.hackclub.dev).

sampoder
sampoder requested changes Nov 7, 2021
View reviewed changes
Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make this optional? Last time I used this thing it wouldn't deploy cause I wasn't using next/image and it drove me insane.

@exu3
Copy link
Member Author

exu3 commented Nov 7, 2021

Yep ignoreDuringBuilds: true should ignore it during builds

@exu3 exu3 requested a review from sampoder November 7, 2021 02:30
sampoder
sampoder approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sick

@sampoder sampoder merged commit cb202d4 into main Nov 7, 2021
@sampoder sampoder deleted the linter branch November 7, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampoder sampoder sampoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exu3 @lachlanjc @sampoder