Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haunted house announcement card #289

Merged
merged 1 commit into from
Oct 20, 2023
Merged

haunted house announcement card #289

merged 1 commit into from
Oct 20, 2023

Conversation

ivoinestrachan
Copy link
Contributor

No description provided.

@lachlanjc
Copy link
Member

📝 Changed routes:

/
Screenshot of /
(view full size)

Commit 72a24b2 (https://hackathons-i3l63nmdo.hackclub.dev).

devramsean0
devramsean0 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@devramsean0 devramsean0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how much I like the placement, (It kinda just feels wrong there)

but LGTM

@radioblahaj
Copy link
Member

@devramsean0 we kept there b/c all the old ones were there too, like epoch! But what do you recommend?

@devramsean0
Copy link
Member

not entirely sure, it just feels wrong. but maybe near where the hackathon grant card is?

@radioblahaj
Copy link
Member

It's also there, so people notice it. We tried a lot of diff placements, but they all looked odd
image
heres one

@radioblahaj
Copy link
Member

*here's one we tried out

@radioblahaj
Copy link
Member

image

grymmy
grymmy approved these changes Oct 19, 2023
View reviewed changes
Copy link

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm at a glance but I did not test, please do so carefully b4 merge

@grymmy grymmy added this pull request to the merge queue Oct 20, 2023
Merged via the queue into hackclub:main with commit a2b69ba Oct 20, 2023
1 check passed
@samdev-7 samdev-7 mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grymmy grymmy grymmy approved these changes

@devramsean0 devramsean0 devramsean0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivoinestrachan @lachlanjc @radioblahaj @devramsean0 @grymmy