Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo_rulefit_boston [nocheck] #5982

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Conversation

koniecsveta
Copy link
Contributor

Rulefit demo that could be linked in the release blogpost. This is better known and it shows that it mimics drf results. Apart of that it is better extendable by the other features that are on the way, because it will be possible to show local/global importances / interactions on it in the same way as it is done in paper.

@koniecsveta koniecsveta changed the title demo_rulefit_boston demo_rulefit_boston [nocheck] Dec 23, 2021
Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @koniecsveta.

I would maybe add some plot of importances after the Rulefit algorithm is applied, to compare it with the DRF.

@maurever
Copy link
Contributor

Please, fix the demo for Python 2.7. ;) It looks like a small issue.

Traceback (most recent call last):
...
  File "<string>", line 14
    from h2o.estimators.rulefit import H2ORuleFitEstimator
    ^
IndentationError: unexpected indent

@koniecsveta
Copy link
Contributor Author

koniecsveta commented Jun 1, 2022

The Boston Housing dataset includes a variable, B, which makes it sensitive regarding Fairness and Ethics in general.

This dataset has been used and then removed by several ML OSS libraries:

To avoid unnecessary negative feedbacks, the dataset should be changed. sklearn (see PR) and facet has switched to the diabetes dataset. -> Sensitive variable removed.

Copy link
Contributor

@michalkurka michalkurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@koniecsveta koniecsveta force-pushed the zuzana/rulefit_boston_demo branch 3 times, most recently from a445660 to d4811db Compare June 2, 2022 12:43
@michalkurka michalkurka merged commit f2cc51d into master Jun 3, 2022
@koniecsveta koniecsveta deleted the zuzana/rulefit_boston_demo branch June 6, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants