Skip to content

Commit

Permalink
GH-15672: setup tempfile directory in standalone_test once per Tomas …
Browse files Browse the repository at this point in the history
…Fryda suggestion. It is also destroyed after each test.
  • Loading branch information
wendycwong committed Aug 15, 2023
1 parent 9b237b0 commit c702d86
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
12 changes: 11 additions & 1 deletion h2o-py/tests/pyunit_utils/utilsPY.py
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,17 @@ def standalone_test(test, init_options={}):
h2o.log_and_echo("STARTING TEST "+test.__name__)
h2o.log_and_echo("")
h2o.log_and_echo("------------------------------------------------------------")
test()
import os
import tempfile
with tempfile.TemporaryDirectory() as dir: # Create a temporary dir that will clean itself
tempfile._once_lock.acquire() # Better lock to avoid race conditions (but since we don't test in multiple threads (to avoid side-effects on the backend) it should not matter)
old_tempdir = tempfile.tempdir
try:
tempfile.tempdir = dir # Tell tempfile to use this temporary dir as the root for all other temporary dirs
test()
finally:
tempfile.tempdir = old_tempdir
tempfile._once_lock.release()

def run_tests(tests, run_in_isolation=True, init_options={}):
#flatten in case of nested tests/test suites
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import tempfile
import os


# Check and make sure transformed gam frame is correctedly saved with h2o.save_moddel
def test_gam_transformed_frame_serialization():
h2o_data = h2o.import_file(
Expand Down

0 comments on commit c702d86

Please sign in to comment.