Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default width to image when -set-default-width is passed #389

Closed
wants to merge 3 commits into from
Closed

Set default width to image when -set-default-width is passed #389

wants to merge 3 commits into from

Conversation

vaibsharma
Copy link
Contributor

Hey @h2non,

This is to add default width field in the image options when -set-default-width is passed.

Please have a look at the PR

@h2non
Copy link
Owner

h2non commented Apr 4, 2022

Why not just pass the width URL param?

@vaibsharma
Copy link
Contributor Author

It could possible that someone just might want to change the format or quality of image but not height and width.

@vaibsharma
Copy link
Contributor Author

vaibsharma commented Apr 5, 2022 •
edited
Loading

@h2non looks like I can use /convert without providing external width param. Closing this PR.

@vaibsharma vaibsharma closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaibsharma @h2non