Skip to content

Commit

Permalink
v2.0.0 fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
raffis committed Feb 19, 2019
1 parent b68cd50 commit fed30ff
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 15 deletions.
12 changes: 6 additions & 6 deletions src/kube/ingress.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export default class Ingress extends Resource {
let service = this.prepareResource(definition);
let templates = this.options.serviceTemplates;
templates = templates.concat(this.prepareTemplates(definition));

if (this.options.applyServices) {
await this.icinga.applyServiceGroup(definition.metadata.namespace);

Expand Down Expand Up @@ -138,14 +138,14 @@ export default class Ingress extends Resource {

/**
* Delete object
*/
*/
protected deleteObject(definition: any): Promise<boolean> {
if (this.options.hostName === null) {
let hostname = this.getHostname(definition);
return this.icinga.deleteHost(hostname);
}
return this.icinga.deleteServicesByFilter('service.vars.kubernetes.metadata.uid=="'+definition.metadata.uid+'"');

return this.icinga.deleteServicesByFilter('service.vars.kubernetes.metadata.uid=="'+definition.metadata.uid+'"');
}

/**
Expand All @@ -164,9 +164,9 @@ export default class Ingress extends Resource {

if (object.type == 'MODIFIED' || object.type == 'DELETED') {
await this.deleteObject(object.object).catch((err) => {
this.logger.error('failed to remove objects', {error: err})
this.logger.error('failed to remove objects', {error: err});
});
}
}

if (object.type == 'ADDED' || object.type == 'MODIFIED') {
this.prepareObject(object.object).catch((err) => {
Expand Down
6 changes: 3 additions & 3 deletions src/kube/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export default class Service extends Resource {

/**
* Delete object
*/
*/
protected deleteObject(definition: any): Promise<boolean> {
let serviceType = definition.spec.type;

Expand All @@ -192,7 +192,7 @@ export default class Service extends Resource {
return this.icinga.deleteHost(hostname);
}

return this.icinga.deleteServicesByFilter('service.vars.kubernetes.metadata.uid=="'+definition.metadata.uid+'"');
return this.icinga.deleteServicesByFilter('service.vars.kubernetes.metadata.uid=="'+definition.metadata.uid+'"');
}

/**
Expand All @@ -216,7 +216,7 @@ export default class Service extends Resource {

if (object.type == 'MODIFIED' || object.type == 'DELETED') {
await this.deleteObject(object.object).catch((err) => {
this.logger.error('failed to remove objects', {error: err})
this.logger.error('failed to remove objects', {error: err});
});
}

Expand Down
9 changes: 5 additions & 4 deletions src/kube/volume.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export default class Volume extends Resource {

if (this.options.applyServices) {
let groups = [];

if (definition.spec.claimRef.namespace) {
groups.push(definition.spec.claimRef.namespace);
await this.icinga.applyServiceGroup(definition.spec.claimRef.namespace);
Expand Down Expand Up @@ -125,15 +126,15 @@ export default class Volume extends Resource {

/**
* Delete object
*/
*/
protected deleteObject(definition: any): Promise<boolean> {
if (this.options.hostName === null) {
let hostname = this.getHostname(definition);
return this.icinga.deleteHost(hostname);
}

return this.icinga.deleteServicesByFilter('service.vars.kubernetes.metadata.uid=="'+definition.metadata.uid+'"');
}
return this.icinga.deleteServicesByFilter('service.vars.kubernetes.metadata.uid=="'+definition.metadata.uid+'"');
}

/**
* Start kube listener
Expand All @@ -151,7 +152,7 @@ export default class Volume extends Resource {

if (object.type == 'MODIFIED' || object.type == 'DELETED') {
await this.deleteObject(object.object).catch((err) => {
this.logger.error('failed to remove objects', {error: err})
this.logger.error('failed to remove objects', {error: err});
});
}

Expand Down
4 changes: 2 additions & 2 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async function main() {
await icinga.deleteServicesByFilter('service.vars._kubernetes == true').catch((err) => {
logger.error('failed to cleanup icinga services', {error: err});
});

await icinga.deleteHostsByFilter('host.vars._kubernetes == true').catch((err) => {
logger.error('failed to cleanup icinga hosts', {error: err});
});
Expand All @@ -46,7 +46,7 @@ async function main() {
return json;
});
}

if (config.kubernetes.volumes.discover) {
kubeVolume.kubeListener(function() {
let json = new JSONStream();
Expand Down

0 comments on commit fed30ff

Please sign in to comment.