Bump Font Awesome to v6 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jennynz, thank you for the PR! PyWaffle contains a copy of Font Awesome otf files, and a mapping file (pywaffle/fontawesome_mapping.py generated by scripts/get_fontawesome.py, the file you updated), could you update them as well? Previous update should be helpful if you don't know where they are #10. |
|
@jennynz Never mind, I have finished the changes. It's merged and you will see it in next version soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Firstly, just wanted to say I absolutely love this package - it works so seamlessly, and you've really thought of everything in terms of how people might want to tweak things to make some beautiful visualisations!
I noticed that Font Awesome released v6 (in Feb 2022) which have quite a few new icons, so I thought I'd bump the version to their latest. Do let me know if it's not just a matter of bumping the version here!