Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Font Awesome as required package #32

Merged
merged 9 commits into from
Jun 7, 2022
Merged

Conversation

gyli
Copy link
Owner

@gyli gyli commented Jun 6, 2022

Fixes #31

… font files manually; Move text handler out of waffle.py to avoid unnecessary import and initialization; Update fontawesome_mapping adding alias; Remove fontawesome otf files
@gyli
Copy link
Owner Author

gyli commented Jun 6, 2022

This fix also includes:

  • Add alias in fontawesome mapping file, which means outdated font names (alias) will be usable in PyWaffle.
  • Move font-related text handler out of waffle.py, and it will only be imported when Font Awesome is used. It will help boosting the loading speed as Font Awesome should be a relatively less common use case.
  • It is (slightly) easier to upgrade Font Awesome package separately now, as users only need to pip update fontawesomefree, while they still need to execute fontawesome_mapping_generator.py under the package folder to refresh mapping file.

@gyli
Copy link
Owner Author

gyli commented Jun 6, 2022

This change will also erase the need of upgrading Font Awesome like in #27 and #10, as there's no more embedded fonts.

@gyli gyli merged commit 3dc4d13 into master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Font Awesome through Python package
1 participant