windows: don't search config files in CWD and $PATH #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config files, like _lesskey, are determined at homefile(...), and on windows, after trying $HOME and $HOMEDRIVE$HOMEPATH, it could fallback to using _searchenv, which first searches CWD and then in $PATH. Disable this fallback on Windows. Note that OS2 and DOS variants (DJGPP, Borland, MS-DOS-compiler) still behave like before, and search CWD and $PATH (assuming they still compile - all the non-DJGPP targets use and used _searchenv, which probably only exists on WIndows). At the very least the DOS variants don't have a notion of $HOME, so it's not obvious where the config files should be searched - if we wanted to address these build targets as well, but for now we don't.
|
Updated the commit message without changes to the code. |
gwsw
added a commit
that referenced
this pull request
Jul 22, 2024
…windows, after trying $HOME and $HOMEDRIVE$HOMEPATH, it could fallback to using _searchenv, which first searches CWD and then in $PATH. Disable this fallback on Windows. Note that OS2 and DOS variants (DJGPP, Borland, MS-DOS-compiler) still behave like before, and search PWD and $PATH (assuming they still compile - all the non-DJGPP targets use and used _searchenv, which probably only exists on WIndows). At the very least the DOS variants don't have a notion of $HOME, so it's not obvious where the config files should be searched - if we wanted to address these build targets as well, but for now we don't. Manual merge of #527.
gwsw
added a commit
that referenced
this pull request
Jul 25, 2024
…windows, after trying $HOME and $HOMEDRIVE$HOMEPATH, it could fallback to using _searchenv, which first searches CWD and then in $PATH. Disable this fallback on Windows. Note that OS2 and DOS variants (DJGPP, Borland, MS-DOS-compiler) still behave like before, and search PWD and $PATH (assuming they still compile - all the non-DJGPP targets use and used _searchenv, which probably only exists on WIndows). At the very least the DOS variants don't have a notion of $HOME, so it's not obvious where the config files should be searched - if we wanted to address these build targets as well, but for now we don't. Manual merge of #527.
|
Manually merged into the post659 branch in 3bcd6c2. |
Did you see my comment two weeks ago here? 1ca819b#commitcomment-144844485 when you accidentally merged it into master? Because it again has the same issue that the commit title dissappeared and each paragraph at the commit message became one line. |
|
Yes I saw that. I did the merge into post659 in 3bcd6c2 on July 24 which was before your comment. Are you suggesting that I amend the commit message? |
Oh, I thought you merged it just before you posted the message. No, don't ammend it. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config files, like _lesskey, are determined at homefile(...), and on windows, after trying $HOME and $HOMEDRIVE$HOMEPATH, it could fallback to using _searchenv, which first searches CWD and then in $PATH.
Disable this fallback on Windows.
Note that OS2 and DOS variants (DJGPP, Borland, MS-DOS-compiler) still behave like before, and search PWD and $PATH (assuming they still compile - all the non-DJGPP targets use and used _searchenv, which probably only exists on WIndows).
At the very least the DOS variants don't have a notion of $HOME, so it's not obvious where the config files should be searched - if we wanted to address these build targets as well, but for now we don't.