Diagnose input preprocessor failures (#258) #315
Conversation
main.c
Outdated
| @@ -409,6 +409,7 @@ quit(status) | |||
| else | |||
| save_status = status; | |||
| quitting = 1; | |||
| edit((char*)NULL); | |||
There was a problem hiding this comment.
What is the purpose of moving the edit() call up here? I think this will break --redraw-on-quit, since the file will be closed when repaint() is called.
There was a problem hiding this comment.
I moved the edit call up so that the diagnosis of the input preprocessor failure would appear in the prompt line on the user's screen. With the edit call where it is in less master, the file is closed and less moves on so the diagnostic message never appears on the user's screen.
Thanks for mentioning the --redraw-on-quit issue. To fix that, I updated the pull request to add a function drain_altpipe that diagnoses the input preprocessor failure without doing the rest of the edit call, and to call drain_altpipe at what I hope is the right point, leaving the call to edit alone. The updated pull request also merges from current master.
This pull request fixes issue #258 - it's like the patch proposed near the end of that issue, except updated so that it merges nicely with the master branch of 'less'.