fix defines.h include order #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defines.h header sets up defines that the C library relies on. By including it *after* C library headers, those defines end up not having any effect. Move them to the first include in these files to fix. More specifically, the LFS flags (_FILE_OFFSET_BITS) are ignored by glibc unless they are defined before glibc headers are included. This fixes LFS support in the lesskey parsing logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defines.h header sets up defines that the C library relies on. By including it after C library headers, those defines end up not having any effect. Move them to the first include in these files to fix.
More specifically, the LFS flags (_FILE_OFFSET_BITS) are ignored by glibc unless they are defined before glibc headers are included. This fixes LFS support in the lesskey parsing logic.