Fix overflows with malformed lesskey lines #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If lines are malformed it is possible to trigger out of boundary read accesses during parsing. Carefully handle the pointer increments to not move behind the terminating nul byte. How to reproduce: python -c 'print(1022*" "+"\\")' > lesskey-1.txt python -c 'print(1022*" "+"^")' > lesskey-2.txt python -c 'print(1021*" "+"\\k")' > lesskey-3.txt Open these files with lesskey, compiled with -fsanitize=address.
|
I did not fuzz possible lesskey files so I do not know if this covers all cases. The last adjustment is probably not necessary -- but I added it just in case. For style reasons it might make sense to modify all *pp = p+1 lines in that function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If lines are malformed it is possible to trigger out of boundary
read accesses during parsing.
Carefully handle the pointer increments to not move behind the
terminating nul byte.
How to reproduce:
python -c 'print(1022*" "+"\")' > lesskey-1.txt
python -c 'print(1022*" "+"^")' > lesskey-2.txt
python -c 'print(1021*" "+"\k")' > lesskey-3.txt
Open these files with lesskey, compiled with -fsanitize=address.