Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPS-LOCK key is added to search strings (Windows version) #5

Closed
ghost opened this issue Sep 10, 2018 · 1 comment
Closed

CAPS-LOCK key is added to search strings (Windows version) #5

ghost opened this issue Sep 10, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 10, 2018

If you're viewing a file and press slash or question mark to initiate a search and then press the CAPS-LOCK key while entering the search string, two characters are displayed and become part of the search string. Those two characters are displayed as "alpha" (code \340) and "colon" (code \072). The two characters must be backspaced-over to erase them otherwise the search will fail.

On a PC, the CAPS-LOCK key generates a two-character scancode: \000 followed by \072. This sequence is defined in the file pckeys.h but is never referenced. The leading zero is replaced by \340 in function "getchr".

I've observed this behavior in Windows XP 32-bit and Windows 10 64-bit apps built using MingW. I suspect this is a problem for all Windows-based compilers for which MSDOS_COMPILER==WIN32C.
rivy added a commit to rivy/less that referenced this issue Jan 29, 2019
@rivy
Fix incorrect CAPS-LOCK and NUM-LOCK key handling (fixes gwsw/less#5)
409dbc8
rivy added a commit to rivy/less that referenced this issue Jan 29, 2019
@rivy
Fix incorrect CAPS-LOCK and NUM-LOCK key handling (fixes gwsw/less#5)
069e947
@gwsw
Copy link
Owner

gwsw commented Jun 3, 2019

Fixed in v539.

@gwsw gwsw closed this as completed Jun 3, 2019
rivy added a commit to rivy/less that referenced this issue Sep 11, 2019
@rivy
Revert "Fix incorrect CAPS-LOCK and NUM-LOCK key handling (fixes gwsw…
e612093 
…/less#5)"

- defer to alternate fix contained in up-v550

This reverts commit 069e947.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gwsw