-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deno support with Denoify #108
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR, I'll take a look at this soon (sorry for the delay, I'm kind of busy lately) |
I know what it is. In your own time! |
Hey! I agree it would be preferable not to track the deno_dist build. Since I'm not so familiar with github actions, so I'd be super interested if you want to setup a basic action to publish new version to deno automatically. If it's too much work, I'll just merge this PR. Quick question, are we still going to need a special build once deno starts supporting npm modules natively as announced here? |
9cb83ca
to
c4858c2
Compare
Hi @gvergnaud !
Good question, theorically no, but I want to use Regarding the CI I'm very glad you asked! What the CI does:
What you need to do:
If you have any question, I'm here to help! |
src/patterns.ts
Outdated
@@ -16,7 +16,7 @@ import { | |||
GuardExcludeP, | |||
} from './types/Pattern'; | |||
|
|||
export { Pattern }; | |||
export type { Pattern }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deno requires that types be exported as type.
<a href="https://github.com/gvergnaud/ts-pattern/actions"> | ||
<img src="https://github.com/gvergnaud/ts-pattern/workflows/ci/badge.svg?branch=main" alt="CI Workflow" height="18"> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
12cc99f
to
bee9c30
Compare
Hi @gvergnaud, A quick up just in case you forgot this PR :) Best, |
Hey @garronej, I haven't forgotten your PR! I'm sorry for the delay, I just didn't have the time to read and understand your github action config and I didn't want to merge something I won't be able to maintain. I have a few questions actually:
|
552a220
to
b26f267
Compare
Hello @gvergnaud,
Understandable. Anyway I'll always be there to assist you if you have any problem with the CI setup.
It tirggers only on the It you want this action to run on a branch that has no open PR on main you can simply edit this line, replacing
Yes, Ryan Dahl wanted it this way. You'll have to use Best regards, |
I have put this PR in draft while I update |
6df69dd
to
48ad365
Compare
48ad365
to
3bea918
Compare
add0a9f
to
d12019c
Compare
Hi @gvergnaud,
You can do that by updating the |
assignement -> assignment
8ec91da
to
7841523
Compare
I've been using Deno for a while, and the one thing I've needed to do use most modern libraries is adding I'm wondering if it's worth waiting for typescript to cut the next release instead of fiddling with the tooling here. |
@gvergnaud I agree, considering that ts-pattern has no dependency and isn't using any Node builtins the approach suggested by @lilnasy works. |
Thanks @garronej so sorry for the many back and forths on this PR, I was still hesitant on merging it because of my lack of familiarity with github actions, and the fact that I don't have a lot of time to dedicate the tooling around this repo :/ |
No problem @gvergnaud, perfectly understandable. |
Hello @gvergnaud, I've decided to reopen this PR, believing that incorporating Denoify, upon further reflection and after evaluating the alternative suggested by @lilnasy, is the most effective strategy. In this updated PR, I've ensured the successful testing of the v5 release in the demo repository. I comprehend your reservations regarding the introduction of a CI workflow that wasn't authored by you, particularly given your limited familiarity with GitHub Action. However, I've taken the liberty of reopening the discussion for several compelling reasons which might alter your perspective:
Ultimately, your project operates under your rules. I've made my argument, and it is your decision whether to move forward or not. If you opt to proceed, these instructions remain applicable. I genuinely hope that my initiative to reopen this PR does not seem excessively persistent. Best regards, |
As a +1, I'm currently writing a plugin for grammY that will benefit greatly from using |
Following up on #33,
As mentioned, it would be cleaner not to track the
deno_dist
directory on the main branch and publish with an action like tsafe or EVT does, I can help you with that if you want but I'd understand if you'd prefer not messing with your CI.After merging what's left for you to do is to publish the module on the third party Deno module repository:
Navigate to deno.land/x, click "Add a module" then follow the instruction. Use
deno_dist/
as subdirectory when asked.Best,