Skip to content

Commit

Permalink
UI bugfixes and tweaks (blakeblackshear#10848)
Browse files Browse the repository at this point in the history
* fix ios z-index scrolling bug

* skeleton size
  • Loading branch information
hawkeye217 committed Apr 5, 2024
1 parent 07ee39b commit 5085fa7
Showing 1 changed file with 27 additions and 24 deletions.
51 changes: 27 additions & 24 deletions web/src/views/events/EventView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -839,31 +839,34 @@ function MotionReview({
return (
<div key={camera.name} className={`relative ${spans}`}>
{motionData ? (
<PreviewPlayer
key={camera.name}
className={`rounded-2xl ${spans} ${grow}`}
camera={camera.name}
timeRange={currentTimeRange}
startTime={previewStart}
cameraPreviews={relevantPreviews || []}
isScrubbing={scrubbing}
onControllerReady={(controller) => {
videoPlayersRef.current[camera.name] = controller;
}}
onClick={() =>
onOpenRecording({
camera: camera.name,
startTime: currentTime,
severity: "significant_motion",
})
}
/>
<>
<PreviewPlayer
className={`rounded-2xl ${spans} ${grow}`}
camera={camera.name}
timeRange={currentTimeRange}
startTime={previewStart}
cameraPreviews={relevantPreviews || []}
isScrubbing={scrubbing}
onControllerReady={(controller) => {
videoPlayersRef.current[camera.name] = controller;
}}
onClick={() =>
onOpenRecording({
camera: camera.name,
startTime: currentTime,
severity: "significant_motion",
})
}
/>
<div
className={`review-item-ring pointer-events-none z-20 absolute rounded-lg inset-0 size-full -outline-offset-[2.8px] outline outline-[3px] ${detectionType ? `outline-severity_${detectionType} shadow-severity_${detectionType}` : "outline-transparent duration-500"}`}
/>
</>
) : (
<Skeleton className={`rounded-2xl ${spans} ${grow}`} />
<Skeleton
className={`rounded-2xl size-full ${spans} ${grow}`}
/>
)}
<div
className={`review-item-ring pointer-events-none z-10 absolute rounded-lg inset-0 size-full -outline-offset-[2.8px] outline outline-[3px] ${detectionType ? `outline-severity_${detectionType} shadow-severity_${detectionType}` : "outline-transparent duration-500"}`}
/>
</div>
);
})}
Expand Down Expand Up @@ -894,7 +897,7 @@ function MotionReview({
dense={isMobile}
/>
) : (
<Skeleton className="rounded-2xl size-full" />
<Skeleton className="size-full" />
)}
</div>

Expand Down

0 comments on commit 5085fa7

Please sign in to comment.