Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup): recursively create backup directory #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions cmd/hostctl/actions/backup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,34 @@ func Test_Backup(t *testing.T) {
+----------+--------+-----------+------------+
`, r.Hostfile(), backupFile)
}

func Test_Backup_Deep_Target(t *testing.T) {
cmd := NewRootCmd()

r := NewRunner(t, cmd, "/deep/backup-deep")
defer r.Clean()

date := time.Now().UTC().Format("20060102")

backupFile := fmt.Sprintf("%s.%s", r.Hostfile(), date)
defer os.Remove(backupFile)

r.Run("hostctl backup --path /tmp/deep").
Containsf(`
[ℹ] Using hosts file: %s

[✔] Backup '%s' created.

+----------+--------+-----------+------------+
| PROFILE | STATUS | IP | DOMAIN |
+----------+--------+-----------+------------+
| default | on | 127.0.0.1 | localhost |
+----------+--------+-----------+------------+
| profile1 | on | 127.0.0.1 | first.loc |
| profile1 | on | 127.0.0.1 | second.loc |
+----------+--------+-----------+------------+
| profile2 | off | 127.0.0.1 | first.loc |
| profile2 | off | 127.0.0.1 | second.loc |
+----------+--------+-----------+------------+
`, r.Hostfile(), backupFile)
}
5 changes: 4 additions & 1 deletion cmd/hostctl/actions/integration_runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"io"
"os"
"path"
"strings"
"testing"

Expand Down Expand Up @@ -141,7 +142,9 @@ func (c *cmdRunner) RunE(cmd string, expectedErr error) Runner {
}

func (c *cmdRunner) TempHostfile(pattern string) *os.File {
file, err := os.CreateTemp("/tmp", fmt.Sprintf("%s_%s_", c.root.Name(), pattern))
deep_path := path.Dir(pattern)
tmp_path := path.Join("/tmp", deep_path)
file, err := os.CreateTemp(tmp_path, fmt.Sprintf("%s_%s_", c.root.Name(), path.Base(pattern)))
as.NoError(c.t, err)

_, _ = file.WriteString(`
Expand Down
12 changes: 11 additions & 1 deletion pkg/file/file_backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,26 @@ package file
import (
"fmt"
"io"
"os"
"path"
"time"
)

// Backup creates a copy of your hosts file to a new location with the date as extension.
// Backup creates a copy of your hosts file to a new location with the date as
// extension. It recursively creates the target directory if it does not exist.
func (f *File) Backup(dst string) (string, error) {
_, _ = f.src.Seek(0, io.SeekStart)
bkpFilename := fmt.Sprintf("%s.%s", f.src.Name(), time.Now().UTC().Format("20060102"))
bkpFilename = path.Join(dst, path.Base(bkpFilename))

// check if directory exists, else make it
if _, err := f.fs.Stat(dst); os.IsNotExist(err) {
err := f.fs.MkdirAll(dst, os.ModePerm)
if err != nil {
return "", err
}
}

b, err := f.fs.Create(bkpFilename)
if err != nil {
return "", err
Expand Down