Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pkg refactor #48

Merged
merged 13 commits into from
Apr 13, 2020
Merged

Feat/pkg refactor #48

merged 13 commits into from
Apr 13, 2020

Conversation

guumaster
Copy link
Owner

@guumaster guumaster commented Apr 13, 2020 •
edited
Loading

big module refactor, with 95 new tests! 🎉

  • Add a decent amount code coverage of all files in pkg directory.
  • Refactor pkg code to expose a better API to use as module.
  • Change semantics to have profiles as arguments instead of flag. Profiles as default argument in commands #37
  • Allow to manage multiple profiles at once. Ex: hostctl disable profile1 profile2...
  • Add mutex to save file to avoid concurrency issues.

Fixes #37
Fixes #39
Closes #47
Related to #45

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.2% 85.2% Coverage
0.0% 0.0% Duplication

@guumaster guumaster added this to the v1.0.0 milestone Apr 13, 2020
@guumaster guumaster mentioned this pull request Apr 13, 2020
Closed
5 tasks
@guumaster guumaster merged commit cae3517 into master Apr 13, 2020
@guumaster guumaster deleted the feat/pkg-refactor branch April 13, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Alphabetic sorting of profiles Batch profile managment Profiles as default argument in commands
1 participant
@guumaster