Remove domains #12
Merged
Remove domains #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/host/disable.go # pkg/host/enable.go # pkg/host/remove.go
guumaster
requested changes
Mar 25, 2020
cmd/remove.go
Outdated
| removeCmd.Flags().Bool("all", false, "Remove all profiles") | ||
|
|
||
| removeCmd.AddCommand(removeDomainsCmd) | ||
| removeDomainsCmd.Flags().Bool("all", false, "Remove all domains") |
There was a problem hiding this comment.
If you remove all domains from a profile, you are effectively removing the profile. I think this all flag is not needed here.
cmd/remove.go
Outdated
| @@ -36,7 +36,10 @@ use 'hosts disable' instead. | |||
| profile, _ := cmd.Flags().GetString("profile") | |||
| dst, _ := cmd.Flags().GetString("host-file") | |||
|
|
|||
| err := host.Remove(dst, profile) | |||
| err := host.RemoveProfile(&host.RemoveProfileOptions{ | |||
There was a problem hiding this comment.
I prefer to have positional parameters in this case. I use to add struct options only for optional params or params with useful defaults. But in this case, all are required.
Suggested change
| err := host.RemoveProfile(&host.RemoveProfileOptions{ | |
| err := host.RemoveProfile(dst, profile) |
cmd/remove.go
Outdated
| profile, _ := cmd.Flags().GetString("profile") | ||
| dst, _ := cmd.Flags().GetString("host-file") | ||
|
|
||
| err := host.RemoveDomains(&host.RemoveDomainsOptions{ |
There was a problem hiding this comment.
Same comment as RemoveProfile above
Suggested change
| err := host.RemoveDomains(&host.RemoveDomainsOptions{ | |
| err := host.RemoveDomains(dst, profile, domains) |
guumaster
approved these changes
Mar 26, 2020
|
🎉 thanks @pacodes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5 added remove domains subcommand