New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domains command #5

Closed

pacodes opened this issue Mar 21, 2020 · 1 comment · Fixed by #12

Labels

Contributor

pacodes commented Mar 21, 2020

Proposing add subcommands:

remove domains [-p profile] [-all] - will remove by name in profile (-p) or hosts file (-all)
remove ip [-p profile] [-all] - will remove by IP in profile (-p) or hosts file (-all)

Owner

guumaster commented Mar 23, 2020

I'm ok with that subcommand as long as follow some ideas I had when creating the tool:

'default' profile shouldn't be touched by hostctl. It should only manage profiles created with the tool.
all domains in a profile should have the same IP, if you need different IP, create a new profile

The second idea is not enforced yet because the parser is too simple, but at some point it should.

guumaster added the feature label

pacodes mentioned this issue

Remove domains #12

Merged

guumaster closed this as completed in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment