update lint issues

guumaster · May 2, 2023 · 911d975 · 911d975
1 parent 2cf00b4
commit 911d975
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -78,7 +78,7 @@ linters:
  - misspell
  - nakedret
  - noctx
- - nolintlint
+ # - nolintlint
  - rowserrcheck
  - scopelint
  - staticcheck

diff --git a/cmd/hostctl/actions/post_action.go b/cmd/hostctl/actions/post_action.go
@@ -74,7 +74,7 @@ func postActionCmd(cmd *cobra.Command, args []string, postCmd *cobra.Command, li
 
 func waitSignalOrDuration(d time.Duration) <-chan struct{} {
  done := make(chan struct{})
- sig := make(chan os.Signal)
+ sig := make(chan os.Signal, 1)
 
  if d < 0 {
  d = -d

diff --git a/cmd/hostctl/actions/sync_docker_test.go b/cmd/hostctl/actions/sync_docker_test.go
@@ -36,7 +36,7 @@ func newClientWithResponse(t *testing.T, resp map[string]string) *client.Client
  t.Helper()
 
  v := "1.22"
- c, err := client.NewClient("tcp:https://fake:2345", v,
+ c, err := client.NewClient("tcp:https://fake:2345", v, //nolint: staticcheck
  &http.Client{
  Transport: transportFunc(func(req *http.Request) (*http.Response, error) {
  url := req.URL.Path

diff --git a/pkg/docker/docker_test.go b/pkg/docker/docker_test.go
@@ -102,7 +102,7 @@ func newClientWithResponse(t *testing.T, resp map[string]string) *client.Client
  t.Helper()
 
  v := "1.22"
- c, err := client.NewClient("tcp:https://fake:2345", v,
+ c, err := client.NewClient("tcp:https://fake:2345", v, //nolint: staticcheck
  &http.Client{
  Transport: transportFunc(func(req *http.Request) (*http.Response, error) {
  url := req.URL.Path
@@ -116,7 +116,7 @@ func newClientWithResponse(t *testing.T, resp map[string]string) *client.Client
  }, nil
  }),
  },
- map[string]string{})
+ map[string]string{}) //nolint: staticcheck
 
  assert.NoError(t, err)
 

diff --git a/pkg/parser/docker_test.go b/pkg/parser/docker_test.go
@@ -130,7 +130,7 @@ func newClientWithResponse(t *testing.T, resp map[string]string) *client.Client
  t.Helper()
 
  v := "1.22"
- c, err := client.NewClient("tcp:https://fake:2345", v,
+ c, err := client.NewClient("tcp:https://fake:2345", v, //nolint: staticcheck
  &http.Client{
  Transport: transportFunc(func(req *http.Request) (*http.Response, error) {
  url := req.URL.Path

diff --git a/pkg/parser/parser.go b/pkg/parser/parser.go
@@ -146,7 +146,7 @@ func parseRouteLine(str string) (*types.Route, bool) {
  if len(clean) == 0 {
  return nil, false
  }
- 
+
  result := endingComment.FindStringSubmatch(clean)
  tResult := strings.TrimSpace(result[1])
  p := strings.Split(tResult, " ")