Skip to content

Commit

Permalink
Use proto2 instead of proto3
Browse files Browse the repository at this point in the history
Travis doesn't support proto3.
  • Loading branch information
ry committed May 22, 2018
1 parent 9ea3978 commit d0a8bac
Show file tree
Hide file tree
Showing 5 changed files with 46 additions and 42 deletions.
6 changes: 3 additions & 3 deletions dispatch.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ func recv(buf []byte) (response []byte) {
msg := &BaseMsg{}
check(proto.Unmarshal(buf, msg))
assert(len(msg.Payload) > 0, "BaseMsg has empty payload.")
subscribers, ok := channels[msg.Channel]
subscribers, ok := channels[*msg.Channel]
if !ok {
panic("No subscribers for channel " + msg.Channel)
panic("No subscribers for channel " + *msg.Channel)
}
for i := 0; i < len(subscribers); i++ {
s := subscribers[i]
Expand All @@ -48,7 +48,7 @@ func Sub(channel string, cb Subscriber) {

func Pub(channel string, payload []byte) {
resChan <- &BaseMsg{
Channel: channel,
Channel: &channel,
Payload: payload,
}
}
Expand Down
8 changes: 4 additions & 4 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ func main() {
out, err := proto.Marshal(&Msg{
Payload: &Msg_Start{
Start: &StartMsg{
Cwd: cwd,
Cwd: &cwd,
Argv: args,
DebugFlag: *flagDebug,
MainJs: main_js,
MainMap: main_map,
DebugFlag: flagDebug,
MainJs: &main_js,
MainMap: &main_map,
},
},
})
Expand Down
46 changes: 23 additions & 23 deletions msg.proto
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
syntax = "proto3";
syntax = "proto2";
package main;

message BaseMsg {
string channel = 1;
bytes payload = 2;
optional string channel = 1;
optional bytes payload = 2;
}

message Msg {
string error = 1;
optional string error = 1;
oneof payload {
StartMsg start = 10;
SourceCodeFetchMsg source_code_fetch = 11;
Expand All @@ -20,43 +20,43 @@ message Msg {
}

message StartMsg {
string cwd = 1;
optional string cwd = 1;
repeated string argv = 2;
bool debug_flag = 3;
string main_js = 4; // The contents of dist/main.js
string main_map = 5; // The contents of dist/main.map
optional bool debug_flag = 3;
optional string main_js = 4; // The contents of dist/main.js
optional string main_map = 5; // The contents of dist/main.map
}

message SourceCodeFetchMsg {
string module_specifier = 1;
string containing_file = 2;
optional string module_specifier = 1;
optional string containing_file = 2;
}

message SourceCodeFetchResMsg {
// If it's a non-http module, moduleName and filename will be the same.
// For http modules, moduleName is its resolved http URL, and filename
// is the location of the locally downloaded source code.
string moduleName = 1;
string filename = 2;
string source_code = 3;
string output_code = 4; // Non-empty only if cached.
optional string moduleName = 1;
optional string filename = 2;
optional string source_code = 3;
optional string output_code = 4; // Non-empty only if cached.
}

message SourceCodeCacheMsg {
string filename = 1;
string source_code = 2;
string output_code = 3;
optional string filename = 1;
optional string source_code = 2;
optional string output_code = 3;
}

message ExitMsg { int32 code = 1; }
message ExitMsg { optional int32 code = 1; }

message TimerStartMsg {
int32 id = 1;
bool interval = 2;
int32 duration = 3; // In milliseconds.
optional int32 id = 1;
optional bool interval = 2;
optional int32 duration = 3; // In milliseconds.
}

message TimerReadyMsg {
int32 id = 1;
bool done = 2;
optional int32 id = 1;
optional bool done = 2;
}
23 changes: 13 additions & 10 deletions os.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ func InitOS() {
switch msg.Payload.(type) {
case *Msg_Exit:
payload := msg.GetExit()
os.Exit(int(payload.Code))
os.Exit(int(*payload.Code))
case *Msg_SourceCodeFetch:
payload := msg.GetSourceCodeFetch()
return HandleSourceCodeFetch(payload.ModuleSpecifier, payload.ContainingFile)
return HandleSourceCodeFetch(*payload.ModuleSpecifier, *payload.ContainingFile)
case *Msg_SourceCodeCache:
payload := msg.GetSourceCodeCache()
return HandleSourceCodeCache(payload.Filename, payload.SourceCode,
payload.OutputCode)
return HandleSourceCodeCache(*payload.Filename, *payload.SourceCode,
*payload.OutputCode)
default:
panic("[os] Unexpected message " + string(buf))
}
Expand All @@ -39,7 +39,8 @@ func HandleSourceCodeFetch(moduleSpecifier string, containingFile string) (out [

defer func() {
if err != nil {
res.Error = err.Error()
var errStr = err.Error()
res.Error = &errStr
}
out, err = proto.Marshal(res)
check(err)
Expand Down Expand Up @@ -72,12 +73,13 @@ func HandleSourceCodeFetch(moduleSpecifier string, containingFile string) (out [
return
}

var sourceCode = string(sourceCodeBuf)
res.Payload = &Msg_SourceCodeFetchRes{
SourceCodeFetchRes: &SourceCodeFetchResMsg{
ModuleName: moduleName,
Filename: filename,
SourceCode: string(sourceCodeBuf),
OutputCode: outputCode,
ModuleName: &moduleName,
Filename: &filename,
SourceCode: &sourceCode,
OutputCode: &outputCode,
},
}
return
Expand All @@ -91,7 +93,8 @@ func HandleSourceCodeCache(filename string, sourceCode string,
err := ioutil.WriteFile(fn, outputCodeBuf, 0600)
res := &Msg{}
if err != nil {
res.Error = err.Error()
var errStr = err.Error()
res.Error = &errStr
}
out, err := proto.Marshal(res)
check(err)
Expand Down
5 changes: 3 additions & 2 deletions timers.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ func InitTimers() {
switch msg.Payload.(type) {
case *Msg_TimerStart:
payload := msg.GetTimerStart()
return HandleTimerStart(payload.Id, payload.Interval, payload.Duration)
return HandleTimerStart(*payload.Id, *payload.Interval,
*payload.Duration)
default:
panic("[timers] Unexpected message " + string(buf))
}
Expand All @@ -27,7 +28,7 @@ func HandleTimerStart(id int32, interval bool, duration int32) []byte {
payload, err := proto.Marshal(&Msg{
Payload: &Msg_TimerReady{
TimerReady: &TimerReadyMsg{
Id: id,
Id: &id,
},
},
})
Expand Down

0 comments on commit d0a8bac

Please sign in to comment.