Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conversion warnings #29

Closed
chfast opened this issue Aug 27, 2019 · 3 comments
Closed

Fix conversion warnings #29

chfast opened this issue Aug 27, 2019 · 3 comments
Assignees
@gulrak
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working low Severity: low
Milestone
v1.2.6

Comments

@chfast
Copy link

chfast commented Aug 27, 2019

Is your feature request related to a problem? Please describe.

This is a header-only library therefore it is usually built with the warning level of the project which includes it. With some additional warnings enabled the filesystem.hpp does not compile cleanly.

Describe the solution you'd like

Build the project with -Wconversion -Wsign-conversion -Wpedantic and fix the reported warnings.
@gulrak gulrak self-assigned this Aug 27, 2019
@gulrak gulrak added bug Something isn't working low Severity: low labels Aug 27, 2019
@gulrak
Copy link
Owner

gulrak commented Aug 27, 2019

That shouldn't be a problem. I will not make it during the week, but I try to get to it during the weekend.

@gulrak gulrak added this to the v1.2.6 milestone Aug 27, 2019
@chfast
Copy link
Author

chfast commented Aug 28, 2019

Ok, no rush. I have a workaround in place (-isystem).

gulrak added a commit that referenced this issue Sep 1, 2019
@gulrak
refs #29, work on stricter warning set
d12bdbe
gulrak added a commit that referenced this issue Sep 1, 2019
@gulrak
refs #29, fixes for MinGW warnings
589219b
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Sep 1, 2019
@gulrak
Copy link
Owner

gulrak commented Sep 21, 2019

Released with v1.2.6

@gulrak gulrak closed this as completed Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulrak gulrak

Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working low Severity: low
Projects
None yet
Milestone
v1.2.6
Development

No branches or pull requests
2 participants
@chfast @gulrak