Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Invalid Link [Docs | Stream-Handbook] #2711

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

Viisheshjain05
Copy link
Contributor

Link referenced to stream-handbook is wrong
This is my first public PR hope this link is correct.

Updated Link - https://www.npmjs.com/package/stream-handbook

Link referenced to stream-handbook is wrong 
This is my first public PR hope this link is correct.

Updated Link - https://www.npmjs.com/package/stream-handbook
@phated
Copy link
Member

phated commented Dec 17, 2022

We don't really want to link this to an npm package, especially one that substack is the only maintainer of... You probably want to use https://github.com/browserify/browserify-handbook

@Viisheshjain05
Copy link
Contributor Author

Reason for chosing npm package -

  • Documentation - How to write node programs with streams which is provided in npm package.
  • The github browserify is not appropriate link for that.

Alternative Options -

  1. We can add new .md inside gulp docs providing better explaination for same.
  2. We can use Morioh stream-handbook this is the same doc on much trusted site.
  3. Remove that link and add alternate links for explaining streams.

Thank you for commenting 😄

@phated
Copy link
Member

phated commented Dec 19, 2022

Thanks for finding alternatives. I didn't fully review the freecodecamp article but it looks good enough.

@phated phated merged commit 85896d4 into gulpjs:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants