Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in guidelines #1851

Closed
MattMS opened this issue Nov 6, 2016 · 2 comments · Fixed by #1854
Closed

Broken links in guidelines #1851

MattMS opened this issue Nov 6, 2016 · 2 comments · Fixed by #1854
Labels
documentation help wanted

Comments

@MattMS
Copy link

MattMS commented Nov 6, 2016

The gulp-header and gulp-footer links on the guidelines page result in a 404.

Should these be updated to the NPM package pages for header and footer instead?

I got those NPM links from a quick Google search, and have not used them before, so I am not sure if they are correct.
@phated
Copy link
Member

phated commented Nov 7, 2016

Please submit a PR. Thanks!

@benhalverson
Copy link
Contributor

@phated I can make a quick PR for this. Should the gulp-concat link also point to the npm link?

benhalverson added a commit to benhalverson/gulp that referenced this issue Nov 8, 2016
@benhalverson
(docs): Fix broken header and footer links closes gulpjs#1851
a71e0b6
@benhalverson benhalverson mentioned this issue Nov 8, 2016
Merged
phated pushed a commit that referenced this issue Nov 8, 2016
@benhalverson @phated
Docs: Fix broken gulp-header/gulp-footer links (closes #1851) (#1854)
54169eb
adityavs added a commit to adityavs/gulp that referenced this issue Dec 6, 2016
@adityavs
Merge pull request #1 from gulpjs/master
eb5fe6b 
Docs: Fix broken gulp-header/gulp-footer links (closes gulpjs#1851) (gulpjs#1854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(docs): Fix broken header and footer links benhalverson/gulp
3 participants
@MattMS @phated @benhalverson