fix: unescape glob-escaped dirnames on output

gulpjs · Jan 27, 2021 · 598c533 · 598c533
1 parent cdbea5f
commit 598c533
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/index.js b/index.js
@@ -7,5 +7,5 @@ var pathDirname = require('path-dirname');
 module.exports = function globParent(str) {
 	str += 'a'; // preserves full path in case of trailing path separator
 	do {str = pathDirname.posix(str)} while (isglob(str));
-	return str;
+	return str.replace(/\\([\*\?\|\[\]\(\)\{\}])/g, '$1');
 };
diff --git a/test.js b/test.js
@@ -60,14 +60,14 @@ describe('glob-parent', function() {
   });
 
   it('should respect escaped characters', function() {
-    assert.equal(gp('path/\\*\\*/subdir/foo.*'), 'path/\\*\\*/subdir');
-    assert.equal(gp('path/\\[\\*\\]/subdir/foo.*'), 'path/\\[\\*\\]/subdir');
+    assert.equal(gp('path/\\*\\*/subdir/foo.*'), 'path/**/subdir');
+    assert.equal(gp('path/\\[\\*\\]/subdir/foo.*'), 'path/[*]/subdir');
     assert.equal(gp('path/\\*(a|b)/subdir/foo.*'), 'path');
-    assert.equal(gp('path/\\*/(a|b)/subdir/foo.*'), 'path/\\*');
-    assert.equal(gp('path/\\*\\(a\\|b\\)/subdir/foo.*'), 'path/\\*\\(a\\|b\\)/subdir');
-    assert.equal(gp('path/\\[foo bar\\]/subdir/foo.*'), 'path/\\[foo bar\\]/subdir');
-    assert.equal(gp('path/\\[bar]/'), 'path/\\[bar]');
-    assert.equal(gp('path/foo \\[bar]/'), 'path/foo \\[bar]');
+    assert.equal(gp('path/\\*/(a|b)/subdir/foo.*'), 'path/*');
+    assert.equal(gp('path/\\*\\(a\\|b\\)/subdir/foo.*'), 'path/*(a|b)/subdir');
+    assert.equal(gp('path/\\[foo bar\\]/subdir/foo.*'), 'path/[foo bar]/subdir');
+    assert.equal(gp('path/\\[bar]/'), 'path/[bar]');
+    assert.equal(gp('path/foo \\[bar]/'), 'path/foo [bar]');
   });
 
   it('should return parent dirname from non-glob paths', function() {