Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify arguments to parallel / series #4

Closed
pkozlowski-opensource opened this issue Jul 28, 2014 · 1 comment · Fixed by #5
Closed

Verify arguments to parallel / series #4

pkozlowski-opensource opened this issue Jul 28, 2014 · 1 comment · Fixed by #5

Comments

@pkozlowski-opensource
Copy link
Contributor

Passing a non-function (ex. undefined) to series / parallel results in an "obscure" error from underlying libraries. Arguments supplied to parallel / series should probably be verified and an explicit error should be thrown if any of the arguments is not a function.

Happy to send a PR if this makes sense.
@phated
Copy link
Member

phated commented Aug 9, 2014

I'm good with that. I have been using assert a lot recently to verify arguments. Since it is part of node core, we won't need another dep. A PR for this would be very welcome.

pkozlowski-opensource added a commit to pkozlowski-opensource/bach that referenced this issue Aug 10, 2014
@pkozlowski-opensource
verify arguments to serries / parallel functions
d1a920c 
Fixes gulpjs#4
Merged
@phated phated closed this as completed in #5 Aug 10, 2014
phated pushed a commit that referenced this issue Jun 27, 2016
@pkozlowski-opensource
verify arguments to serries / parallel functions
2e48b4a 
Fixes #4
phated pushed a commit that referenced this issue Jun 27, 2016
@pkozlowski-opensource @phated
Fix: Verify arguments to series/parallel functions (fixes #4)
45b358b
phated pushed a commit that referenced this issue Jun 27, 2016
@pkozlowski-opensource @phated
Fix: Verify arguments to series/parallel functions (fixes #4)
ca32513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

verify arguments to serries / parallel functions pkozlowski-opensource/bach
2 participants
@pkozlowski-opensource @phated