Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing lodash modules #28

Closed
phated opened this issue Feb 22, 2017 · 5 comments
Closed

Consider removing lodash modules #28

phated opened this issue Feb 22, 2017 · 5 comments

Comments

@phated
Copy link
Member

phated commented Feb 22, 2017

If we can find frozen modules that are battle tested to replace them, we should probably switch.

@jonschlinkert
Copy link

@phated I have some libs that might help for some of them.

that are battle tested

I'll add some download stats for them, I'll leave it to you to decide if they make sense for bach. If you decide any of them are ok, I'll make sure they get bumped to 1.0 etc if they aren't.

@phated
Copy link
Member Author

phated commented Feb 22, 2017

@jonschlinkert I believe we are using map and reduce to iterate over objects or arrays

@jonschlinkert
Copy link

got it, "collections" not just arrays. I have collection-map does both objects and arrays - the underlying libs are pretty heavily used but it's light on the downloads, probably b/c of the name. I also have object.map and object.reduce, but obviously those wouldn't work since they only handle objects.

@doowb
Copy link
Member

doowb commented Feb 22, 2017

collection-map handles both objects or arrays.
for-own will handle both objects and arrays.

... @jonschlinkert just responded right before I hit "Comment"

@doowb
Copy link
Member

doowb commented Feb 22, 2017

I mentioned for-own above, but that would be a replacement for lodash.foreach which is only being used on arrays in bach. If that's the case, then array-each should be a good replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants