Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3564. todo list tweaks #3565

Merged

Conversation

dodexahedron
Copy link
Collaborator

Here we go.

All done with this.

Nice little enhancement to the todo list experience.

Fixes

Proposed Changes/Todos

  • Make todo list regexes cover more cases
  • Make todo list regexes work on multi-line comment style
  • Enable support for multiple tags on one line
  • Added a second-priority naming rule for underscore tolerance

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@dodexahedron dodexahedron requested a review from tig as a code owner June 25, 2024 12:12
@tig
Copy link
Collaborator

tig commented Jun 26, 2024

The build error is because of a test error I introduced in the hotkey PR. I'll fix asap.

@BDisp
Copy link
Collaborator

BDisp commented Jun 26, 2024

The build error is because of a test error I introduced in the hotkey PR. I'll fix asap.

@tig do you think that the hotkey PR, also broken the Accept event not being raising on a default button when the Enter key is pressed?

@tig
Copy link
Collaborator

tig commented Jun 26, 2024

The build error is because of a test error I introduced in the hotkey PR. I'll fix asap.

@tig do you think that the hotkey PR, also broken the Accept event not being raising on a default button when the Enter key is pressed?

Seems fine to me?

Note that if the TextFields have focus, it doesn't work because TextField has registered ENTER.

nuTWrak 1

@BDisp
Copy link
Collaborator

BDisp commented Jun 26, 2024

Note that if the TextFields have focus, it doesn't work because TextField has registered ENTER.

But TextField should return false if Multiline is false and thus the Enter key will be caught by the button.

@dodexahedron
Copy link
Collaborator Author

Gah. That's not what I wanted. I forgot that's how github does that...

Hang on

@dodexahedron dodexahedron force-pushed the v2_3564_dodexahedron_todo_list_tweaks branch from 3cb7446 to 0db51b1 Compare June 27, 2024 02:29
@dodexahedron dodexahedron force-pushed the v2_3564_dodexahedron_todo_list_tweaks branch from 0db51b1 to f13786f Compare June 27, 2024 02:32
@dodexahedron
Copy link
Collaborator Author

There we go.

Re-based on v2_develop 61699d6

@dodexahedron
Copy link
Collaborator Author

I am gonna make them all search strings and comments, so they work for the unit test skips and such, as mentioned elsewhere. So hold off for a sec. Figured I'd do those here rather than this one and then changing them in another branch too. 🤷‍♂️

@dodexahedron dodexahedron marked this pull request as draft June 28, 2024 01:28
@dodexahedron dodexahedron marked this pull request as ready for review June 28, 2024 03:57
@dodexahedron
Copy link
Collaborator Author

Okie dokie

All done with that.

Ready whenever.

@dodexahedron
Copy link
Collaborator Author

It was difficult reading their nasty XML.

So I split those into a separate "layer" and manually organized the XML...

In any case, the layer thing is kinda nice, so you can turn blocks of settings on and off at will, in your environment, without having to mess around with solution local settings, which override everything and just make it difficult to sort out.

For example, if you don't like the settings from a layer, you can turn them off for yourself by just un-checking that layer in the options manager, rather than redundantly overriding them with settings you already set for your local computer settings.

@tig tig merged commit 13cbdab into gui-cs:v2_develop Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants