Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable bool checked #2313

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Nullable bool checked #2313

merged 5 commits into from
Feb 3, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Feb 3, 2023

Fixes #2306 - This feature will allow using the three states of a nullable bool (null, true or false) on Menu and CheckBox views.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

checkbox-null-checked

menu-null-checked

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tig tig merged commit 5ca7408 into gui-cs:v2 Feb 3, 2023
@BDisp BDisp deleted the nullable-bool-checked branch February 3, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants