Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old Border class and add a simple way of turning on/off a border #2486

Closed
tig opened this issue Apr 4, 2023 · 1 comment
Closed

Remove the old Border class and add a simple way of turning on/off a border #2486

tig opened this issue Apr 4, 2023 · 1 comment
Labels
v2 For discussions, issues, etc... relavant for v2

Comments

@tig
Copy link
Collaborator

tig commented Apr 4, 2023 •
edited
Loading

  • Delete Border.cs
  • Rename BorderFrame to Border (or Adornments; I haven't decided yet).
  • Add to View a helper. E.g.
public BorderStyle BorderStyle { get; set; } = BorderStyle.None;

The set will change Adornments.Thickness and Adornments.BorderStyle as appropriate.
@tig tig added the v2 For discussions, issues, etc... relavant for v2 label Apr 4, 2023
@tig tig mentioned this issue Apr 4, 2023
Merged
tig added a commit that referenced this issue Apr 10, 2023
@tig
Fixes #2486 - Removes old Border and fixes a litany of related thin…
a637f8a 
…gs (#2525)

* Added View.BorderStyle and renamed BorderStyle enum to LineStyle

* Fixed a lot of things and broke everything else

* Fixed things

* Updated DialogTests

* Updates including Rect unit tests

* Fixed Dialog & MessagBox tests

* Fixed AllviewsTester bug

* Fixed AllviewsTester bug

* Removed Border class

* Renamed View privates with _

* Removed comments in MessageBox.cs
@tig
Copy link
Collaborator Author

tig commented Apr 11, 2023

Fixed by #2486

@tig tig closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2 For discussions, issues, etc... relavant for v2
Projects
No open projects
Terminal.Gui V2 Beta
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tig