Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Do not use end_unsafe in <Variant as From<VariantDict>>::from #1497

Merged
merged 1 commit into from
Sep 1, 2024
Merged

glib: Do not use end_unsafe in <Variant as From<VariantDict>>::from #1497

merged 1 commit into from
Sep 1, 2024

Conversation

kawadakk
Copy link
Contributor

While this method consumes a given VariantDict, the underlying object could still be accessed through other clones because of the reference counted clone semantics, which means it's unsound to use VariantDict::end_unsafe here.

@kawadakk kawadakk force-pushed the patch/fix-variant-dict-into-variant branch from 8630251 to 4aaa9ce Compare August 30, 2024 02:18
@kawadakk
glib: Do not use end_unsafe in <Variant as From<VariantDict>>::from
72a74ab 
While this method consumes a given `VariantDict`, the underlying object
could still be accessed through other clones because of the reference
counted clone semantics.
@kawadakk kawadakk force-pushed the patch/fix-variant-dict-into-variant branch from 4aaa9ce to 72a74ab Compare August 30, 2024 02:34
@sdroege sdroege added the needs-backport PR needs backporting to the current stable branch label Sep 1, 2024
sdroege
sdroege approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sdroege sdroege merged commit 7638251 into gtk-rs:master Sep 1, 2024
48 checks passed
@kawadakk kawadakk deleted the patch/fix-variant-dict-into-variant branch September 2, 2024 01:32
@sdroege sdroege added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
backported PR was backported to the current stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kawadakk @sdroege