Fix the SEARCH transform on bad indexes.

Fixes lp#1769218

package-data-list.lisp-expr

@@ -1347,7 +1347,7 @@ possibly temporarily, because it might be used internally."
  "LL-KWDS-RESTP" "LL-KWDS-KEYP" "LL-KWDS-ALLOWP"
  "MAKE-MACRO-LAMBDA"
  "PROPER-LIST-OF-LENGTH-P" "PROPER-LIST-P"
- "LIST-OF-LENGTH-AT-LEAST-P"
+ "LIST-OF-LENGTH-AT-LEAST-P" "SEQUENCE-OF-LENGTH-AT-LEAST-P"
  "LIST-WITH-LENGTH-P"
  "SINGLETON-P" "ENSURE-LIST"
  "MISSING-ARG"

src/code/early-extensions.lisp

@@ -190,6 +190,15 @@
  (or (zerop n) ; since anything can be considered an improper list of length 0
  (and (consp rest) (rec (cdr rest) (1- n))))))
 
+(defun sequence-of-length-at-least-p (sequence length)
+ (etypecase sequence
+ (list
+ (list-of-length-at-least-p sequence length))
+ (vector
+ (>= (length sequence) length))
+ (sequence
+ (>= (length sequence) length))))
+
 ;;; Is X is a positive prime integer?
 (defun positive-primep (x)
  ;; This happens to be called only from one place in sbcl-0.7.0, and

src/compiler/seqtran.lisp

@@ -1288,7 +1288,9 @@
  (length pattern))
  (t
  (give-up-ir1-transform))))
- (pattern (if (= (- pattern-end pattern-start) 1)
+ (pattern (if (and (= (- pattern-end pattern-start) 1)
+ (sequence-of-length-at-least-p pattern
+ (1+ pattern-start)))
  (elt pattern pattern-start)
  (give-up-ir1-transform))))
  (macrolet ((maybe-arg (arg &optional (key (keywordicate arg)))

tests/bad-code.pure.lisp

@@ -354,3 +354,8 @@
  (checked-compile
  '(lambda () (encode-universal-time 0 0 0 1 1 1900 -1))
  :allow-style-warnings t))))
+
+(with-test (:name :search-transform-bad-index)
+ (checked-compile
+ '(lambda (a)
+ (search '(0 1 0 2) a :start1 4 :end1 5))))