Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.8 #146

Merged
merged 1 commit into from
Aug 19, 2015
Merged

Release 0.3.8 #146

merged 1 commit into from
Aug 19, 2015

Conversation

egilkh
Copy link
Contributor

@egilkh egilkh commented Aug 19, 2015

Should fix #139

egilkh added a commit that referenced this pull request Aug 19, 2015
@egilkh egilkh merged commit 1ea74bc into gsklee:master Aug 19, 2015
@williamboman
Copy link
Contributor

Feels like it should have been a 0.4.0 considering the amount and nature of 0.3.7..HEAD changes? Anyways, 👍 thanks!

@egilkh
Copy link
Contributor Author

egilkh commented Aug 19, 2015

You are right it should have :)

But I was thinking since the public api part that most people use hasn't been impacted (only more to be used if you want) it might have been confusing. On the other hand, most people probably won't notice if it's 0.3.8 or 0.4.0 :)

@williamboman
Copy link
Contributor

The move over to providers might cause some issues for people. The official semver page dictates that MINOR should be bumped when

[...] you add functionality in a backwards-compatible manner

Anyways, tomayto tomahto 😄.

@egilkh
Copy link
Contributor Author

egilkh commented Aug 19, 2015

Damn it! You win 😃

@williamboman
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create release 0.3.8
2 participants