Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/improvments #222

Merged
merged 10 commits into from
Feb 18, 2024
Merged

feat/improvments #222

merged 10 commits into from
Feb 18, 2024

Conversation

lorenzhh
Copy link
Collaborator

@lorenzhh lorenzhh commented Jan 6, 2024 •
edited
Loading

Features:

  1. Support custom animation duration, default: 200ms
  2. On Right Mouse Click cancel move while dragging

Improvments:

  1. Remove unnecessary NgxChessBoardService
  2. UpdateBoard() needs a boardLoader
  3. MoveChange Interface: added missing properties
  4. Having multiple instanses of boards in the same view cause to use the same arrow id of last board. if last one is hidden, arrow wont display

@lorenzhh
Copy link
Collaborator Author

@grzegorz103 Reminder

@grzegorz103 grzegorz103 merged commit a7bab77 into master Feb 18, 2024
itcantbe added a commit to itcantbe/ngx-chess-board that referenced this pull request Aug 1, 2024
@itcantbe
Revert "Merge pull request grzegorz103#222 from grzegorz103/feat/impr…
6e57a72 
…ovments"

This reverts commit a7bab77, reversing
changes made to c9e4c77.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorz103 grzegorz103 Awaiting requested review from grzegorz103

Assignees

@grzegorz103 grzegorz103

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzhh @grzegorz103