Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP: simplify installation #5249

Merged
merged 2 commits into from
Feb 24, 2016

Conversation

stanley-cheung
Copy link
Contributor

  • For PHP installation is too complex #4517 "PHP installation is too complex" and Create binary artifacts for PHP distribution package #4771 "Create binary artifacts for PHP distribution package"
  • Template-ize config.m4 and package.xml. Moved these 2 files all the way up to the base grpc/ directory
  • Now a simple pear package command will build the PHP PECL package and gives a package named similar to grpc-0.8.0.tgz
  • Now PHP installation can be simplified to these 2 commands (on Debian at least)
    • sudo apt-get install -y php5 php5-dev php-pear phpunit
    • sudo pecl install grpc-beta
  • Added a bunch of scripts to hook up with Jenkins continuous building and testing the PHP PECL package

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@stanley-cheung
Copy link
Contributor Author

Here's a full Jenkins run building and testing the PHP PECL package: https://grpc-testing.appspot.com/view/Artifacts/job/gRPC_distribtest/118/

@stanley-cheung stanley-cheung force-pushed the php-build-template branch 2 times, most recently from 26613fe to 873b51c Compare February 17, 2016 00:16

pecl install grpc-php.tgz

php -d extension=grpc.so -d max_execution_time=300 distribtest.php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would people need to always invoke with php -d extension=grpc.so when they want to use grpc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Users can (and should) add that flag to the php.ini file. There are various mechanism / location for that file depending on how PHP is invoked (cli, apache, nginx, etc).

@jtattermusch
Copy link
Contributor

this is ok to test

@jtattermusch
Copy link
Contributor

Besides the minor nits, basically looks good to me.

@jtattermusch
Copy link
Contributor

ping, are you planning to fix the nits?

@stanley-cheung stanley-cheung force-pushed the php-build-template branch 2 times, most recently from 811186b to a01a5b1 Compare February 24, 2016 05:22
@stanley-cheung stanley-cheung force-pushed the php-build-template branch 3 times, most recently from 7ec8314 to 829e940 Compare February 24, 2016 06:34
@stanley-cheung
Copy link
Contributor Author

stanley-cheung added a commit that referenced this pull request Feb 24, 2016
@stanley-cheung stanley-cheung merged commit 91edc13 into grpc:master Feb 24, 2016
@stanley-cheung stanley-cheung deleted the php-build-template branch February 24, 2016 16:05
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants