Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up grpc_py_binary build rule #14609

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Clean up grpc_py_binary build rule #14609

merged 1 commit into from
Mar 7, 2018

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Mar 6, 2018

No description provided.

@apolcyn apolcyn requested a review from dgquintas March 6, 2018 19:58
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@apolcyn apolcyn mentioned this pull request Mar 6, 2018
Merged
@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@apolcyn
Copy link
Contributor Author

apolcyn commented Mar 6, 2018

artifact macos build failure is due to TIMEOUT: build_artifact.python_macos_x64_python3.5

@apolcyn apolcyn merged commit 14b470a into grpc:master Mar 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
@lock lock bot unassigned dgquintas Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgquintas dgquintas dgquintas approved these changes

@a11r a11r Awaiting requested review from a11r

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@vjpai vjpai Awaiting requested review from vjpai

Assignees
No one assigned
Labels
kind/internal cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apolcyn @grpc-testing @dgquintas