Use static_cast rather than reinterpret_cast whenever possible #14597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dgquintas
reviewed
Mar 5, 2018
test/core/util/trickle_endpoint.cc
Outdated
| @@ -132,7 +132,7 @@ static int te_get_fd(grpc_endpoint* ep) { | |||
| } | |||
|
|
|||
| static void te_finish_write(void* arg, grpc_error* error) { | |||
| trickle_endpoint* te = static_cast<trickle_endpoint*>(arg); | |||
| trickle_endpoint* te = reinterpret_cast<trickle_endpoint*>(arg); | |||
There was a problem hiding this comment.
If static_cast was compiling here, why switch to reinterpret_cast?
There was a problem hiding this comment.
Oops, I slipped. Thanks for noticing.
There was a problem hiding this comment.
Specifically, my method here was to s/reinterpret_cast/static_cast/g, get all the build errors and change those back with an Emacs macro. Looks like I slipped here. I'll check the others.
|
|
1 similar comment
|
markdroth
approved these changes
Mar 5, 2018
|
1 similar comment
|
|
Thanks for doing this Vijay! From the errors, it looks like some of the conversions weren't part of a hierarchy or void * to and fro conversions. LGTM once it builds :) |
|
I wasn't building Cronet until now. Hopefully this goes through now. |
|
|
|
|
|
1 similar comment
|
|
Rebased, diff unchanged |
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, you should use
static_castfor going up or down a class hierarchy or for converting betweenT*andvoid*.Many of the remaining uses of
reinterpret_castare for things that are "morally" part of a class hierarchy (e.g.,grpc_endpointvsmock_endpoint) but currently aren't because they are expressed in C-style. This will allow further reduction ofreinterpret_castin the future.