Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asan failure in fake_resolver_test. #14582

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Fix asan failure in fake_resolver_test. #14582

merged 1 commit into from
Mar 5, 2018

Conversation

markdroth
Copy link
Member

Fixes #14581.

@markdroth markdroth requested a review from adelez March 2, 2018 22:39
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@markdroth
Copy link
Member Author

Both of the test failures look like infrastructure problems in new tests.

@markdroth markdroth merged commit aa7fa51 into grpc:master Mar 5, 2018
@markdroth markdroth deleted the fake_resolver_test_fix branch March 5, 2018 18:15
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelez adelez adelez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markdroth @grpc-testing @adelez