Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print trailing metadata in the "grpc_cli call" command. #14478

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

cookyt
Copy link
Contributor

@cookyt cookyt commented Feb 21, 2018

This often includes important debugging information when the RPC returns
a non-OK status.

@sreecha sreecha requested a review from y-zeng February 21, 2018 23:36
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@sreecha sreecha self-requested a review February 21, 2018 23:37
This often includes important debugging information when the RPC returns
a non-OK status.
@y-zeng
Copy link
Contributor

y-zeng commented Feb 22, 2018

Can we only print the trailing metadata when the RPC returns a non-OK status?

@cookyt
Copy link
Contributor Author

cookyt commented Feb 22, 2018

Trailing metadata could be useful even for OK responses, and the PrintMetadata function will only print metadata if the given metadata parameter is non-empty, so unconditionally printing it won't create unneeded terminal spam.

@grpc-testing
Copy link

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link

[trickle] No significant performance differences

@grpc-testing
Copy link

[microbenchmarks] No significant performance differences

@vjpai vjpai merged commit d3f7c0f into grpc:master Mar 5, 2018
@cookyt cookyt deleted the tool-print-trailing-meta branch March 5, 2018 23:58
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants