Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzer tests for Bazel #14395

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Fix fuzzer tests for Bazel #14395

merged 2 commits into from
Feb 13, 2018

Conversation

adelez
Copy link
Contributor

@adelez adelez commented Feb 9, 2018

Also piggyback a minor change to the build file for bad_ssl.

@grpc-testing
Copy link

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link

[trickle] No significant performance differences

@grpc-testing
Copy link

[microbenchmarks] No significant performance differences

@adelez
Copy link
Contributor Author

adelez commented Feb 10, 2018

The fuzzer tests pass but Bazel Build Basic test is failing because of
ERROR: /var/local/git/grpc/test/core/nanopb/BUILD:23:1: Traceback (most recent call last):
File "/var/local/git/grpc/test/core/nanopb/BUILD", line 23
grpc_fuzzer(name = "fuzzer_response", srcs = [..."], <3 more arguments>)
File "/var/local/git/grpc/test/core/util/grpc_fuzzer.bzl", line 18, in grpc_fuzzer
grpc_cc_test(name = name, srcs = srcs, deps = dep..."], <4 more arguments>)
File "/var/local/git/grpc/test/core/util/grpc_fuzzer.bzl", line 26, in grpc_cc_test
native.package_name()
struct has no method 'package_name'.

Here's the result running on my experimental job: https://source.cloud.google.com/results/invocations/6c9d5806-352d-44b7-afa2-05ebd9df5f58/targets/%2F%2Ftest%2Fcore%2Fend2end%2Ffuzzers:api_fuzzer@poller%3Depoll1/tests

I'm looking.

@adelez
Copy link
Contributor Author

adelez commented Feb 13, 2018

The same test passed on Foundry with canary bazel.

@grpc-testing
Copy link

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link

[trickle] No significant performance differences

@grpc-testing
Copy link

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@adelez
Copy link
Contributor Author

adelez commented Feb 13, 2018

Upgrading bazel to 0.9.0 worked.

@grpc-testing
Copy link

[trickle] No significant performance differences

@adelez adelez merged commit 8224c45 into grpc:master Feb 13, 2018
@grpc-testing
Copy link

[microbenchmarks] No significant performance differences

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants