Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ParseCommandLineFlags in golden file test in the same way that other test binaries use it #13838

Merged
merged 2 commits into from
Dec 20, 2017
Merged

Use ParseCommandLineFlags in golden file test in the same way that other test binaries use it #13838

merged 2 commits into from
Dec 20, 2017

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Dec 20, 2017

No description provided.

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_unary_ping_pong.BM_UnaryPingPong_InProcessCHTTP2_NoOpMutator_NoOpMutator__0_8.opt.new: 1


[microbenchmarks] No significant performance differences

@dgquintas
Copy link
Contributor

look at all that green!

@apolcyn apolcyn merged commit 343522c into grpc:master Dec 20, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yang-g yang-g yang-g approved these changes

@dgquintas dgquintas dgquintas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apolcyn @grpc-testing @dgquintas @yang-g