php_protobuf_plugin: update checking reserved variables with protobuf 3.5.0 #13580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhouyihaiDing
commented
Nov 30, 2017
src/compiler/php_generator.cc
Outdated
| @@ -21,6 +21,7 @@ | |||
| #include "src/compiler/config.h" | |||
| #include "src/compiler/generator_helpers.h" | |||
| #include "src/compiler/php_generator_helpers.h" | |||
| #include <google/protobuf/compiler/php/php_generator.h> | |||
There was a problem hiding this comment.
I am not sure it is better to leave it here(only this file use it), or move it to config.h to make it looks like grpc::protobuf::compiler::php
7a3b8d5
to
b6f8f60
Compare
ZhouyihaiDing
commented
Dec 11, 2017
| #include "src/compiler/config.h" | ||
| #include "src/compiler/generator_helpers.h" | ||
| #include "src/compiler/php_generator_helpers.h" | ||
|
|
||
| using google::protobuf::compiler::php::GeneratedClassName; |
There was a problem hiding this comment.
Hi, @jtattermusch . Can you please give me an advise here? Do I need to move include #include <google/protobuf/compiler/php/php_generator.h> to config.h and make it grpc::protobuf::compiler::php?
b6f8f60
to
39a4746
Compare
|
Bazel Debug build for C/C++ and Bazel Opt build for C/C++ look like infrastructure problems in new tests. |
|
stanley-cheung
approved these changes
Mar 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the issue #13285
Currently, protobuf is bumped to 3.5.0. There are more reserved variables in this version and php plugin can use the new API provided to check reserved variables.