Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate dot in enum name (when "package" is specified) #1286

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

sampajano
Copy link
Collaborator

@sampajano sampajano commented Sep 26, 2022

Summary

Changes

  • This fix makes StripPrefixString remove the leading dot when stripping out a prefix -- and hence will work in both cases (with and without package).
  • Also removed a few now redundant logic to remove leading dots.

Tested

Fixes #1284

@sampajano sampajano changed the title Fix duplicate dot in enum name Fix duplicate dot in enum name (when "package" is specified) Sep 26, 2022
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sampajano sampajano merged commit 8a12309 into grpc:master Sep 27, 2022
@sampajano sampajano deleted the 1.fix.duplicate.dot branch September 27, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate dot after enum's namespace in typescript file when using dot in package name
2 participants