stats: Add optional locality label in cluster_impl picker #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7434 +/- ##
==========================================
+ Coverage 81.44% 81.51% +0.06%
==========================================
Files 352 352
Lines 26919 26927 +8
==========================================
+ Hits 21924 21949 +25
+ Misses 3804 3795 -9
+ Partials 1191 1183 -8
|
f105d52
to
d508527
Compare
|
Got to all comments; no approval yet though so assigning back to you. |
dfawley
approved these changes
Jul 24, 2024
| @@ -150,7 +150,12 @@ func (h *clientStatsHandler) TagRPC(ctx context.Context, info *stats.RPCTagInfo) | |||
| var labels *istats.Labels | |||
| if labels = istats.GetLabels(ctx); labels == nil { | |||
| labels = &istats.Labels{ | |||
| TelemetryLabels: make(map[string]string), | |||
| // The defaults for all the per call label from a plugin that | |||
There was a problem hiding this comment.
Nits:
"labelS"
"on the call path"
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the setting of the optional locality label in the cluster_impl picker for per call metrics. It also sets the default of "" for this label in OpenTelemetry.
RELEASE NOTES: N/A