Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: use locality from the connected address for load reporting #7378

Merged
merged 9 commits into from
Jul 10, 2024
Merged

xds: use locality from the connected address for load reporting #7378

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
08ebd15
xds: Use the connected address for locality (#7357)
townba Jul 1, 2024
32d869b
Address review comments #1
townba Jul 2, 2024
5070034
Remove unused function
townba Jul 2, 2024
8709e78
Reflow comment.
townba Jul 2, 2024
18bce36
Remove setting locality in `NewSubConn`.
townba Jul 2, 2024
69acfcf
Address review comments (2/x).
townba Jul 8, 2024
66478fb
Address review comments (3/x).
townba Jul 8, 2024
c5a4ade
Address review comments (4/x).
townba Jul 8, 2024
64ae662
Address review comments (5/x).
townba Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused function
  • Loading branch information
@townba
townba committed Jul 2, 2024
commit 50700344105983baaa9bc8827614b44598c718d3
7 changes: 0 additions & 7 deletions clientconn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,13 +812,6 @@ func (cc *ClientConn) applyFailingLBLocked(sc *serviceconfig.ParseResult) {
cc.csMgr.updateState(connectivity.TransientFailure)
}

// addressWithoutBalancerAttributes returns a copy of the input address with
// the BalancerAttributes field cleared.
func addressWithoutBalancerAttributes(a resolver.Address) resolver.Address {
a.BalancerAttributes = nil
return a
}

// Makes a copy of the input addresses slice. Addresses are passed during
// subconn creation and address update operations.
func copyAddresses(in []resolver.Address) []resolver.Address {
Expand Down
Loading