Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add a test for NewSubConn / StateListener / cc.Close racing #6678

Merged
merged 1 commit into from
Oct 4, 2023
Merged

client: add a test for NewSubConn / StateListener / cc.Close racing #6678

merged 1 commit into from
Oct 4, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 3, 2023 •
edited by arvindbr8
Loading

RELEASE NOTES: none

@dfawley dfawley added this to the 1.59 Release milestone Oct 3, 2023
@dfawley dfawley requested a review from arvindbr8 October 3, 2023 16:45
arvindbr8
arvindbr8 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. updated description to make Mergeable happy.

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Oct 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6678 (79c4a79) into master (39972fd) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@dfawley dfawley merged commit 696faa9 into grpc:master Oct 4, 2023
12 checks passed
@dfawley dfawley deleted the notstarted branch October 4, 2023 22:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Testing
Projects
None yet
Milestone
1.59 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dfawley @codecov-commenter @arvindbr8