Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/c2p: fix default client resource template, and xds-client target scheme #5010

Merged
merged 2 commits into from
Nov 30, 2021
Merged

xds/c2p: fix default client resource template, and xds-client target scheme #5010

merged 2 commits into from
Nov 30, 2021

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Nov 29, 2021 •
edited
Loading

Default client resource scheme should be %s, otherwise the client will watch an empty string LDS resource.

RELEASE NOTES: N/A

@menghanl menghanl added this to the 1.43 release milestone Nov 29, 2021
@dfawley dfawley assigned menghanl and unassigned dfawley Nov 30, 2021
@menghanl menghanl merged commit 872a6f1 into grpc:master Nov 30, 2021
@menghanl menghanl deleted the c2p_resolver_fix branch November 30, 2021 23:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: Bug
Projects
None yet
Milestone
1.43 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @dfawley