internal: move leakcheck to t.Cleanup #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
requested changes
Nov 16, 2021
internal/grpctest/grpctest.go
Outdated
Comment on lines
101
to
102
| // Run leakcheck in t.Cleanup() to guarantee it is run even if tfunc | ||
| // uses t.Fatal(). |
There was a problem hiding this comment.
Should this go above setup for the same reason?
internal/grpctest/grpctest.go
Outdated
Comment on lines
104
to
106
| // Note that defer doesn't work it runs before t.Cleanup, and a | ||
| // goroutine is closed in a t.Cleanup, a deferred leakcheck will | ||
| // fail. |
There was a problem hiding this comment.
Wording here looks strange. How about:
// Note that a defer would run before t.Cleanup, so if a goroutine is closed
// by a test's t.Cleanup, a deferred leakcheck would fail.Or something
dfawley
approved these changes
Nov 17, 2021
| @@ -97,9 +97,13 @@ func RunSubTests(t *testing.T, x interface{}) { | |||
| } | |||
| tfunc := getTestFunc(t, xv, methodName) | |||
| t.Run(strings.TrimPrefix(methodName, "Test"), func(t *testing.T) { | |||
| // Run leakcheck in t.Cleanup() to guarantee it is run even if tfunc | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: N/A