xds/client: move watchers from xdsclient to a separate struct #4963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
force-pushed
the
xds_client_rafactor_step_2
branch
from
970cafc
to
94a5c5c
Compare
|
@easwars This PR has a lot of trivial changes caused by moving types between packages. |
easwars
approved these changes
Nov 8, 2021
Comment on lines
28
to
32
| v, ok := c[s] | ||
| if !ok { | ||
| return nil | ||
| } | ||
| return v.Raw |
There was a problem hiding this comment.
Maybe? (just saves one line per case, but overall it makes the function shorter).
if v, ok := c[s]; ok {
return v.Raw
}
return nil
… to a separate struct - a new pubsub package to manage the watchers - it also handles new updates, and calls the watcher callbacks - move more types to package xdsresource - most of the changes in tests and other packages are due to this - this is necessary to avoid cycular dependency (xdsclient -> pubsub -> xdsclient's types)
menghanl
force-pushed
the
xds_client_rafactor_step_2
branch
from
f5d3306
to
f37daa6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pubsubpackage to manage the watchersRELEASE NOTES: N/A